This repository was archived by the owner on Oct 9, 2023. It is now read-only.
[Doc] Add Go / dependencies installation instructions#561
Open
kevin85421 wants to merge 1 commit intoflyteorg:masterfrom
Open
[Doc] Add Go / dependencies installation instructions#561kevin85421 wants to merge 1 commit intoflyteorg:masterfrom
kevin85421 wants to merge 1 commit intoflyteorg:masterfrom
Conversation
EngHabu
reviewed
May 14, 2023
Contributor
EngHabu
left a comment
EngHabu
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Can you use this: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet
To reference the current top line of go.mod? In case it changes in the future and we forget to update instructions here?
Author
|
Hi @EngHabu, thank you for the review! Do you prefer a permanent link or a normal link? Example:
|
Contributor
|
Permanent Link I believe will show if there is a mismatch. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
as title
Type
Are all requirements met?
The instructions are similar to: https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#use-go-v117.
Complete description
as title
Tracking Issue
NA
Follow-up issue
NA